Improve build cache and Docker container management#70
Open
Somnius wants to merge 1 commit intoomacom-io:mainfrom
Open
Improve build cache and Docker container management#70Somnius wants to merge 1 commit intoomacom-io:mainfrom
Somnius wants to merge 1 commit intoomacom-io:mainfrom
Conversation
- Change package cache from daily to 24-hour window (hourly timestamps) * Prevents rapid Arch package updates from breaking ISO builds * Cache format: iso_YYYYMMDD_HH (e.g., iso_20260111_14) * Valid for 24 hours from first build in that hour - Add Docker container cleanup with named containers * Use named containers: omarchy-iso-build-$(id -u) (user-specific) * Automatically clean up previous containers before build * Clean up container after build completes * Safe: only touches containers with exact name - Add omarchy-iso-make-local convenience script * Wrapper for building with local source * Pre-configured environment variables * Useful for local development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the ISO build process with better package caching and Docker container management.
Changes
1. 24-Hour Package Cache Window
Problem: Arch packages update rapidly (multiple times per day). Daily cache can break builds mid-day when packages are updated.
Solution: Changed cache from daily to 24-hour window with hourly timestamps.
iso_YYYYMMDD_HH(e.g.,iso_20260111_14)~/.cache/omarchy/iso_YYYYMMDD_HH/Example:
iso_20260111_14(reused until 14:00 next day)iso_20260111_15(new hourly cache)iso_20260112_14(24h window expired)2. Docker Container Cleanup
Problem: Previous builds left containers running or stopped, causing conflicts and accumulation.
Solution: Use named containers with automatic cleanup.
omarchy-iso-build-$(id -u)(user-specific)Benefits:
3. Convenience Script (Bonus)
Added
omarchy-iso-make-localas a convenience wrapper for local development:OMARCHY_PATHautomaticallyFiles Changed
bin/omarchy-iso-make- Cache and container management improvementsbin/omarchy-iso-make-local- New convenience script (optional, can be removed if not needed)Testing
--no-cacheflag (still works)Backward Compatibility
--no-cacheflag still works